Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove cross region snapshot copy 5s delay #1938

Merged
merged 1 commit into from
Aug 24, 2023
Merged

fix: remove cross region snapshot copy 5s delay #1938

merged 1 commit into from
Aug 24, 2023

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Aug 22, 2023 •
edited
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix: remove cross region snapshot copy 5s delay

when waiting for cross region snapshot copy, this driver will always wait 5s first and then check status, this PR check status first.

  • original behavior
I0814 11:11:57.703460       1 controllerserver.go:962] create snapshot(snapshot-d915b42f-9930-496a-bc0e-b2a749ff5c30) under rg(azuredisk-csi-driver-test-5e8268fe-3a93-11ee-8f63-4eadf895f413) region(westus2) successfully
I0814 11:12:02.808176       1 azuredisk.go:435] copy snapshot(snapshot-d915b42f-9930-496a-bc0e-b2a749ff5c30) under rg(azuredisk-csi-driver-test-5e8268fe-3a93-11ee-8f63-4eadf895f413) region(westus2) completionPercent: 0.000000
  • with this PR(saving 5s):
I0822 15:47:05.342477       1 controllerserver.go:953] begin to create snapshot(snapshot-252375a1-ff67-4cd3-97be-43f014a2aed1, incremental: true) under rg(azuredisk-csi-driver-test-5c25a425-4102-11ee-aa8d-9a7759610fdc) region(westus2)
I0822 15:47:07.999237       1 controllerserver.go:962] create snapshot(snapshot-252375a1-ff67-4cd3-97be-43f014a2aed1) under rg(azuredisk-csi-driver-test-5c25a425-4102-11ee-aa8d-9a7759610fdc) region(westus2) successfully
I0822 15:47:08.096070       1 azuredisk.go:443] copy snapshot(snapshot-252375a1-ff67-4cd3-97be-43f014a2aed1) under rg(azuredisk-csi-driver-test-5c25a425-4102-11ee-aa8d-9a7759610fdc) complete
I0822 15:47:08.096099       1 controllerserver.go:968] begin to delete snapshot(local_snapshot-252375a1-ff67-4cd3-97be-43f014a2aed1) under rg(azuredisk-csi-driver-test-5c25a425-4102-11ee-aa8d-9a7759610fdc) region(eastus)
I0822 15:47:13.289084       1 controllerserver.go:973] delete snapshot(local_snapshot-252375a1-ff67-4cd3-97be-43f014a2aed1) under rg(azuredisk-csi-driver-test-5c25a425-4102-11ee-aa8d-9a7759610fdc) region(eastus) successfully

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

fix: remove cross region snapshot copy 5s delay

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 22, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2023
@k8s-ci-robot
Copy link
Contributor

@andyzhangx: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azuredisk-csi-driver-external-e2e-single-az f8cfae3 link true /test pull-azuredisk-csi-driver-external-e2e-single-az
pull-azuredisk-csi-driver-e2e-capz-windows-2022-hostprocess f8cfae3 link true /test pull-azuredisk-csi-driver-e2e-capz-windows-2022-hostprocess
pull-azuredisk-csi-driver-e2e-capz-windows-2022 f8cfae3 link true /test pull-azuredisk-csi-driver-e2e-capz-windows-2022

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andyzhangx andyzhangx merged commit 7b24049 into kubernetes-sigs:master Aug 24, 2023
10 checks passed
@andyzhangx
Copy link
Member Author

/cherrypick release-1.28

@k8s-infra-cherrypick-robot
Copy link

@andyzhangx: new pull request created: #1941

In response to this:

/cherrypick release-1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Aug 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvvz cvvz Awaiting requested review from cvvz

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andyzhangx @k8s-ci-robot @k8s-infra-cherrypick-robot